Bayesian fixes - #332
Merged
Merged
Conversation
rozyczko
added a commit
that referenced
this pull request
Aug 3, 2026
* initial version. * updates to the parameter passing * nice Bayesian sub-tabs display * add parameter names, add cancellation of sampling, add number of steps in status bar * correct parenting * added required dependencies and modified Fit Status dialog * add save button to the plots * added tests for bayesian logic * attempt at getting posterior median and credibility intervals on the main chart * enable/disable legends on bayesian sampling * reload bumps images on recalculation. Use different caption when running sampling * updates and changes, new unit tests and GUI elements. New colors * fixed typo * actually sample multiple experiments * nicer plots * trace plot - nice display * updated plots * changes for the new EasyList based reflectometry-lib * changes after updates to core * unit test fixed * weird conflict * Bayesian fixes (#332) * removed MD file, fixed #312 * fixed #313 * Fixed issues #312 - #322 Temporarily commented out code signing * Addressed issues #323, #324, #325, #326 * addressed #327, #328, #329 * update paths in the Summary textboxes * minor updates based on the new ERL * summary results now show correct GoF #375 * reparent to released lib
rozyczko
added a commit
that referenced
this pull request
Aug 3, 2026
* summary prettified (#308) * summary prettified * minor fixes after code review * make links clickable (#310) * Bayesian analysis (#309) * initial version. * updates to the parameter passing * nice Bayesian sub-tabs display * add parameter names, add cancellation of sampling, add number of steps in status bar * correct parenting * added required dependencies and modified Fit Status dialog * add save button to the plots * added tests for bayesian logic * attempt at getting posterior median and credibility intervals on the main chart * enable/disable legends on bayesian sampling * reload bumps images on recalculation. Use different caption when running sampling * updates and changes, new unit tests and GUI elements. New colors * fixed typo * actually sample multiple experiments * nicer plots * trace plot - nice display * updated plots * changes for the new EasyList based reflectometry-lib * changes after updates to core * unit test fixed * weird conflict * Bayesian fixes (#332) * removed MD file, fixed #312 * fixed #313 * Fixed issues #312 - #322 Temporarily commented out code signing * Addressed issues #323, #324, #325, #326 * addressed #327, #328, #329 * update paths in the Summary textboxes * minor updates based on the new ERL * summary results now show correct GoF #375 * reparent to released lib * fixes from code review (#334) * updated versioning (#335)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements across the codebase, focusing on error handling, logging, and code robustness, particularly in the Bayesian analysis and experiment management logic. It also includes changes to the minimizer selection behavior and some minor API and naming cleanups. The most important changes are grouped below.
Bayesian Analysis Improvements
_set_bayesian_attrto handle invalid Bayesian hyper-parameter assignments gracefully, logging warnings and ensuring the UI remains consistent. Updated all Bayesian setter slots to use this helper._on_sample_finishedto log errors for empty or invalid results, ensuring that UI signals are always emitted even on failure.posteriorproperty inbayesian.pyto allow safe assignment of posterior results.np.isfinitefor more robust filtering.Logging and Error Reporting
printstatements withlogger.warningorlogger.exceptionin experiment and parameter management code, ensuring errors are consistently logged and easier to trace.Minimizer and Experiment Selection Logic
set_minimizer_current_indexto prevent out-of-range minimizer selections.collect_selected_experiments_datagrouptocollect_all_experiments_datagroupand clarified that Bayesian sampling always runs over all experiments, not just selected ones.API and Naming Cleanups
home.pyand updated the way version and release date are accessed fromPYPROJECT.phaseCounttomodelsCountfor clarity.Miscellaneous
setTerminationEnabledon threads, improving compatibility and stability.localFileToUrlhelper to always useQUrl.fromLocalFile, removing special handling for Windows.